Improved meshbuilder's mesh handling #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoferigo
requested changes
Jun 4, 2024
src/rod/builder/primitives.py
Outdated
| @@ -74,20 +74,12 @@ def __post_init__(self) -> None: | |||
| AssertionError: If the scale is not a 3D vector. | |||
| TypeError: If the mesh_path is not a str or pathlib.Path. | |||
| """ | |||
| mesh_path = pathlib.Path(self.mesh_path) | |||
There was a problem hiding this comment.
Last nit, this attribute could already be a pathlib.Path object:
Suggested change
| mesh_path = pathlib.Path(self.mesh_path) | |
| mesh_path = self.mesh_path if isinstance(self.mesh_path, pathlib.Path) else pathlib.Path(self.mesh_path) |
diegoferigo
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
I updated the suggestion @lorycontixd, merging. Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, I suggest to move the mesh loading part inside of a context manager to ensure that the file is properly closed, but most importantly to avoid a bug from trimesh where a string can be passed to
trimesh.load_mesh, but internally it requires a file-like object. This way, the mesh is instantly loaded using a file object.Also, I added a logging warning from
MeshBuilderwhen an empty mesh is loaded.